Allow for different ways of providing consumer_key config #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently a hard-coded reference to the optional
app_key
parameter of the Flask-OAuthlib library. Resultingin a
KeyError
being raised if it is not present.invenio-oauthclient/invenio_oauthclient/handlers/utils.py
Line 86 in 4aaa9c5
Using the
app_key
is a way to lazy load theconsumer_key
andconsumer_secret
, but it is possible toprovide them directly. It will have to be either, otherwise the remote app won't load.
This PR also removes a duplication of defining the
remote_apps
variable and fixes some documentation.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: