Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different ways of providing consumer_key config #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

J4bbi
Copy link

@J4bbi J4bbi commented Oct 3, 2024

Description

There is currently a hard-coded reference to the optional app_key parameter of the Flask-OAuthlib library. Resulting
in a KeyError being raised if it is not present.

remote_app_config = current_app.config[remote_app["params"]["app_key"]]

Using the app_key is a way to lazy load the consumer_key and consumer_secret, but it is possible to
provide them directly. It will have to be either, otherwise the remote app won't load.

This PR also removes a duplication of defining the remote_apps variable and fixes some documentation.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant