Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: add comment notification for subcoms #1256

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

carlinmack
Copy link
Contributor

❤️ Thank you for your contribution!

Close inveniosoftware/invenio-requests#417

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

{% set request_id = invenio_request.id %}
{% set request_event_content = invenio_request_event.payload.content | safe %}
{% set request_title = invenio_request.title | safe %}
{% set child_community = invenio_request.receiver.slug %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only line different between the two functions

@carlinmack carlinmack force-pushed the fix-comments branch 2 times, most recently from 5224606 to dcdab52 Compare December 4, 2024 14:48
@ntarocco
Copy link
Contributor

ntarocco commented Dec 5, 2024

Is this fixing somehow the notifications for comments in an inclusion/review request for a community too (not only sub-community)?

@slint
Copy link
Member

slint commented Dec 9, 2024

Is this fixing somehow the notifications for comments in an inclusion/review request for a community too (not only sub-community)?

These are defined in invenio-rdm-records, but the fact that we now have the comment_notification_builder attribute on the request, means that we can override it per-request type and adjust recipients based on their type (users or communities).

@slint slint merged commit a8aae71 into inveniosoftware:master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requests: fix comment notifications
3 participants