[#855] 4) membership request flow frontend integration #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenekku
changed the title
fenekku
force-pushed
the
855_4_request_flow_frontend_integration
branch
2 times, most recently
from
be11589 to
9f968cb
Compare
fenekku
changed the title
fenekku
force-pushed
the
855_4_request_flow_frontend_integration
branch
from
9f968cb to
1ae8d3f
Compare
|
rebased - should fail until the dependent PRs are merged and released. |
fenekku
force-pushed
the
855_4_request_flow_frontend_integration
branch
3 times, most recently
from
0e7dc13 to
db7ead5
Compare
…tend [+] This concludes the 2nd flow of the membership request feature. Remaining flows are - 'waiting for decision' flow - 'making a decision' flow This PR needs to be complemented by: - one in invenio-requests (done) - one in invenio-rdm-records (to do)
fenekku
force-pushed
the
855_4_request_flow_frontend_integration
branch
from
db7ead5 to
a5e0c0c
Compare
fenekku
commented
Jul 19, 2024
| @@ -0,0 +1,338 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Moved from tests/members/test_members_services.py to resolve flaky tests
slint
approved these changes
Jul 29, 2024
|
I will merge this one to get all the previous ones in at the same time. Then I will rebase and cleanup the next ones and communicate again. Thanks! |
This was referenced Jul 30, 2024
[#855] 2) header-ui: request flow ui start inert (no backend nor frontend integration with it)
#1130
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one
This concludes the 2nd flow of the membership request feature.
Remaining flows are
This PR depends on: inveniosoftware/invenio-requests#382 (well not directly but for full effect)
Screencast
Screencast.from.05-07-2024.02.16.56.PM.webm
(Note: "Deleted User" is something I get locally even without any of my code changes from this and previous PRs. As such putting that aside)
Previous ones