Footer: prevent footer overflow on short pages #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix, looks good to me! |
dfdan
force-pushed
the
fix_footer_overflow
branch
from
03d38d3 to
dce2027
Compare
dfdan
changed the title
|
Rebased against master. |
|
This PR was automatically marked as stale. |
kpsherva
reviewed
Aug 22, 2024
| @@ -36,6 +36,7 @@ | |||
| .row.footer-bottom, .sub-footer { | |||
| background-color: @footerDarkColor; | |||
| box-shadow: 0 2px 5px rgba(0, 0, 0, .2) inset; | |||
| padding-bottom: 1rem 0 1rem; | |||
There was a problem hiding this comment.
did you mean:
Suggested change
| padding-bottom: 1rem 0 1rem; | |
| padding-bottom: @defaultPaddding; |
the attribute with specific direction (-bottom, -top, etc) usually takes only one value, unless the notation changed recently and I am not aware, please correct me :)
There was a problem hiding this comment.
(accepted your change below)
There was a problem hiding this comment.
what about this one? it still has 3 values and I am not sure I understand what is it supposed to do, sorry for silly questions if it is obvious!
kpsherva
reviewed
Aug 22, 2024
invenio_app_rdm/theme/assets/semantic-ui/less/invenio_app_rdm/theme/globals/site.overrides
Outdated
Show resolved
Hide resolved
Co-authored-by: Karolina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Add padding to .footer-bottom to prevent footer from overflowing. Closes #2183.
Before:
After:
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: