bug: add handler for handling changed domain

[carlinmack]

❤️ Thank you for your contribution!

(Part of) Close inveniosoftware/invenio-app-rdm#2777

Description

Please describe briefly your pull request.

We call mark_changed but we did not check that it handled Domains

Calling flush as similarly done in the pre-commit hook

Also remove setting of role.id as the added flush() will add the ID from DB

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[lnielsen]

@slint Can you have a look at the impact of having a flush here.

[slint]

I see we very often tiptoe around flushes, and get them in implicitly just by chance because we perform another SELECT query down the line, e.g.:

domain = Domain.create(...)

# ...in another function...

user = UserAggregate.get(...)  # <-- this triggered a flush, so our `domain`
                               #     from above now has a `domain.id`

So I think it's better to be explicit about it, which is what calling mark_changed also implies (i.e. that something will be persisted to the DB).

@carlinmack is also checking this change on tests across other repos to see if there are wrong expectations.

[zubeydecivelek]

LGTU! 🚀 Peer reviewed with @jrcastro2