Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

names: add ORCiD public data sync #682

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jrcastro2
Copy link
Contributor

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let you merge/wait since not familiar with bigger picture of this: is this only available in v12? if so targeting dev branch is probably better. If valid for before v12, master is good and if > 12, then ... I guess we park it 😄

@utnapischtim
Copy link
Contributor

i think this is referring to inveniosoftware/invenio-vocabularies#366. it is v13

That would mean it the flag for _Introduced in v13_ should be set or?

@utnapischtim
Copy link
Contributor

we should really discuss how we handle that sort of documentation. i think waiting until the next version will be released is not a good option. IMHO. it produce a lot more work afterwards.

@slint
Copy link
Member

slint commented Jul 24, 2024

we should really discuss how we handle that sort of documentation. i think waiting until the next version will be released is not a good option. IMHO. it produce a lot more work afterwards.

I fully agree, we should add a _Introduced in v13_ in this case and just merge in master. I will be a bit chaotic, but I don't see another way that doesn't make it very difficult to maintain different versions of docs in sync.

@jrcastro2 jrcastro2 force-pushed the add-orcid-public-data-sync branch 2 times, most recently from 9e42eab to b9c4ae2 Compare July 24, 2024 15:13
@utnapischtim
Copy link
Contributor

I fully agree, we should add a _Introduced in v13_ in this case and just merge in master. I will be a bit chaotic, but I don't see another way that doesn't make it very difficult to maintain different versions of docs in sync.

good, but i think we should wait until dev and so v12 documentation has been merged. otherwise it would be little bit strange to see v13 documentation but no v12 documentation

@fenekku
Copy link
Collaborator

fenekku commented Jul 24, 2024

I fully agree, we should add a _Introduced in v13_ in this case and just merge in master. I will be a bit chaotic, but I don't see another way that doesn't make it very difficult to maintain different versions of docs in sync.

good, but i think we should wait until dev and so v12 documentation has been merged. otherwise it would be little bit strange to see v13 documentation but no v12 documentation

Yup, that's what I meant by parking it. 🚗

@ntarocco
Copy link
Contributor

Normally, we merge to master only things that are in the current (v12) or previous versions.

Anything else for future version should:

  • have the sub-header Introduced in InvenioRDM v...
  • merged to dev branch

When realising a new InvenioRDM version, the dev branch should be merged to master

@ntarocco ntarocco changed the base branch from master to dev August 20, 2024 08:30
@ntarocco
Copy link
Contributor

I have changed the target branch. However, dev might need rebase on top of master.
@jrcastro2 can you add the sub-header?

@jrcastro2
Copy link
Contributor Author

jrcastro2 commented Aug 26, 2024

I have changed the target branch. However, dev might need rebase on top of master. @jrcastro2 can you add the sub-header?

Added.
image

@jrcastro2 jrcastro2 force-pushed the add-orcid-public-data-sync branch from b9c4ae2 to a2b3046 Compare August 26, 2024 07:44
@jrcastro2 jrcastro2 force-pushed the add-orcid-public-data-sync branch from a2b3046 to eea443b Compare August 26, 2024 07:47
@ntarocco ntarocco merged commit df8b0ef into inveniosoftware:dev Aug 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORCID Public Data Sync differential import
5 participants