-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
names: add ORCiD public data sync #682
names: add ORCiD public data sync #682
Conversation
jrcastro2
commented
Jul 24, 2024
- closes ORCID Public Data Sync differential import invenio-vocabularies#353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll let you merge/wait since not familiar with bigger picture of this: is this only available in v12? if so targeting dev
branch is probably better. If valid for before v12, master
is good and if > 12
, then ... I guess we park it 😄
i think this is referring to inveniosoftware/invenio-vocabularies#366. it is v13 That would mean it the flag for |
we should really discuss how we handle that sort of documentation. i think waiting until the next version will be released is not a good option. IMHO. it produce a lot more work afterwards. |
I fully agree, we should add a |
9e42eab
to
b9c4ae2
Compare
good, but i think we should wait until dev and so v12 documentation has been merged. otherwise it would be little bit strange to see v13 documentation but no v12 documentation |
Yup, that's what I meant by parking it. 🚗 |
Normally, we merge to Anything else for future version should:
When realising a new InvenioRDM version, the |
I have changed the target branch. However, |
|
b9c4ae2
to
a2b3046
Compare
a2b3046
to
eea443b
Compare