Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 2fa branch into dev #255

Merged
merged 80 commits into from
Oct 10, 2024
Merged

Merge 2fa branch into dev #255

merged 80 commits into from
Oct 10, 2024

Conversation

SBriere
Copy link
Member

@SBriere SBriere commented Oct 10, 2024

The document is based on this template

By submitting a PR to this repository, you agree to the terms within the Code of Conduct.
Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Merge multi factor authentication and new login process into dev branch.

References

#253

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR
  • I have formatted the files
  • All active GitHub checks for tests are passing
  • The correct base branch is being used, if not main

doumdi and others added 30 commits September 5, 2024 13:59
@doumdi
Refs #253 Updated requirements for pyotp
f15bba0
@doumdi
Refs #253, Added 2fa columns to t_users
8f95e7a
@doumdi
Refs #253, added new columns to ignored fields.
a55e535
@doumdi
Refs #253, starting 2FA API.
8764879
@doumdi
Refs #253, starting 2FA API. logout user when 2fa fails.
cfddb38
@doumdi
Refs #253 Updated base implementation with exceptions.
7009500
@doumdi
Refs #253 Updated base implementation with exceptions.
73eb372
@doumdi
Refs #253 First tests with login views and 2fa.
af1cb32
@doumdi
Refs #253 Working login flow with otp enabled.
c22049b
@doumdi
Refs #253 Sending JSON output when logged in.
b6c8ba5
@doumdi
Refs #253, testing Qt app with webchannel.
c0c9b6a
@doumdi
Refs #253, working Qt with webchannel.
17ae671
@doumdi
Refs #253, implementing change password, work in progress
5a3e837
@doumdi
Refs #253, implementing change password, work in progress
125084a
@doumdi
Refs #253, updating requirements.
1070e6c
@doumdi
Refs #253, fixing tests for vscode.
cdb084f
@SBriere
Refs #253. Updated login view visuals.
21e2d8d
@doumdi
Refs #253, cleaning up login procedure using API, now able to log if …
feafedc 
…2fa is not enabled
@doumdi
Refs #253, merging changes
ef3d23a
@SBriere
Refs #253. Conditional use of QWebChannel in login (don't use if not …
af97f4c 
…defined)
@doumdi
Refs #253, Setting up setup 2FA api.
15feecc
@doumdi
Refs #253, Working Setup 2FA api.
ff7c01d
@SBriere
Refs #253. Login view UI adjustments
bb35762
@SBriere
Merge branch '2fa-dev' of https://github.com/introlab/opentera into 2…
94a4e8a 
…fa-dev
@SBriere
Refs #253. Removed WWW-Authenticate from headers when using basic aut…
8829f7e 
…h to prevent browser pop-up
@SBriere
Refs #253. Updated translations
e78bd53
@doumdi
Refs #253, Maximum 5 2FA attempts in an hour.
72afb43
@doumdi
Refs #253, Maximum 5 2FA attempts in an hour. Simplified and fixed lo…
2dc69a5 
…gic.
@doumdi
Refs #253, Maximum 5 2FA attempts in an hour. Simplified and fixed lo…
3b93a56 
…gic.
@doumdi
Refs #253, Maximum 5 2FA attempts in an hour. Simplified and fixed lo…
b6be74b 
…gic. Code cleanup.
SBriere and others added 23 commits October 4, 2024 11:43
@SBriere
Merge branch '2fa-dev' of https://github.com/introlab/opentera into 2…
f8c9a3f 
…fa-dev
@doumdi
Refs #253, Reimplementation if after_update, after_insert events not …
317d66c 
…using relationships.
@doumdi
Refs #253, Reimplementation if after_update, after_insert events not …
b7a8f8d 
…using relationships. To be validated.
@SBriere
Merge branch '2fa-dev' of https://github.com/introlab/opentera into 2…
3ec3a63 
…fa-dev
@doumdi
Refs #253, cleanup DBManager, fix tests.
a97650f
@doumdi
Refs #253, force reset password for admin on first login.
27defa9
@doumdi
Refs #253, fix tests.
f851261
@SBriere
Refs #253. Updated login 2fa API paths in views. Work started on logi…
c531739 
…n - change password user API.
@SBriere
Merge branch '2fa-dev' of https://github.com/introlab/opentera into 2…
269d478 
…fa-dev
@doumdi
Refs #253, cleanup test.
a64e99a
@doumdi
Merge branch '2fa-dev' of github.com:introlab/opentera into 2fa-dev
802d4c3
@doumdi
Refs #253, added site tests and user tests with 2fa enabled.
3c46086
@SBriere
Refs #253. Added tests for User Login Change Password
a1840a1
@SBriere
Merge branch '2fa-dev' of https://github.com/introlab/opentera into 2…
aea6eb5 
…fa-dev
@doumdi
Refs #253, Fix typos.
9dbde4a
@SBriere
Merge branch '2fa-dev' of https://github.com/introlab/opentera into 2…
168f631 
…fa-dev
@doumdi
Refs #253, Add verification for superadmins.
a08f314
@doumdi
Merge branch '2fa-dev' of github.com:introlab/opentera into 2fa-dev
5b90d8a
@SBriere
Refs #253. Fixed backwards forms compatibility for OpenTeraPlus <= 1.2.x
398a7a6
@doumdi
Refs #253, Add tests for 2fa with superadmins.
a07f2d1
@doumdi
Refs #253, Code cleanup.
7bde014
@doumdi
Refs #253, Code cleanup.
a42bb28
@SBriere
Refs #253. Updated translations
5881536
@SBriere SBriere requested a review from doumdi October 10, 2024 15:40
@doumdi doumdi merged commit dee5369 into dev Oct 10, 2024
1 check passed
@doumdi doumdi deleted the 2fa-dev branch October 10, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doumdi doumdi doumdi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBriere @doumdi