refactor: replace options calls by appropriate get requests #1714
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nchout configuration * requires ICM 12.2.1
…le customer payment methods * requires ICM 11.10.0
SGrueber
added
refactoring
… oci punchout configuration
SGrueber
force-pushed
the
refactor/replace_options_calls
branch
from
c2ba592 to
08956d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the GA release of ICM 12.2.1 before this PR can be merged
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Options calls are used to fetch the oci punchout configurations as well as the customer payment methods. This is not the way to go anymore and can cause CORS issues if the ICM web adapter is not configured properly.
Issue Number: Closes #
What Is the New Behavior?
Alternative 'get' requests are used to fetch the data mentioned above.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Required ICM versions:
11.10.0 and above to fetch the customer payment methods
12.2.1 and above to fetch the oci punchout configuration