chore: move line-item edit button to toolbar

intershop · Dec 15, 2023 · d5cc3bd · d5cc3bd
1 parent a5f2205
commit d5cc3bd
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 27 deletions.
diff --git a/src/app/shared/components/line-item/line-item-edit/line-item-edit.component.html b/src/app/shared/components/line-item/line-item-edit/line-item-edit.component.html
@@ -2,11 +2,11 @@
   <a
     [routerLink]="[]"
     (click)="show()"
-    class="line-item-edit-link"
+    class="line-item-edit-link btn-tool"
     rel="nofollow"
     title="{{ 'checkout.variation.edit.button.label' | translate }}"
-    >{{ 'checkout.variation.edit.button.label' | translate }}</a
-  >
+    ><fa-icon [icon]="['fas', 'pencil']"
+  /></a>
 </ng-container>
 <ish-modal-dialog
   #modalDialog

diff --git a/.../shared/components/line-item/line-item-list-element/line-item-list-element.component.html b/.../shared/components/line-item/line-item-list-element/line-item-list-element.component.html
@@ -39,11 +39,6 @@
 
         <!-- default lineItemViewType -->
         <ng-container *ngSwitchDefault>
-          <!-- edit variation & quantity -->
-          <ng-container *ngIf="editable">
-            <ish-line-item-edit [lineItem]="pli" (updateItem)="onUpdateItem($event)" />
-          </ng-container>
-
           <!-- availability -->
           <ish-product-inventory />
 
@@ -92,6 +87,9 @@
         >
           <fa-icon [icon]="['fas', 'trash-alt']" />
         </a>
+        <ng-container *ngIf="editable">
+          <ish-line-item-edit [lineItem]="pli" (updateItem)="onUpdateItem($event)" />
+        </ng-container>
       </div>
     </div>
 

diff --git a/...ared/components/line-item/line-item-list-element/line-item-list-element.component.spec.ts b/...ared/components/line-item/line-item-list-element/line-item-list-element.component.spec.ts
@@ -131,25 +131,25 @@ describe('Line Item List Element Component', () => {
   it('should display standard elements for normal products', () => {
     fixture.detectChanges();
     expect(findAllCustomElements(element)).toMatchInlineSnapshot(`
-        [
-          "ish-product-image",
-          "ish-product-name",
-          "ish-product-id",
-          "ish-line-item-custom-fields",
-          "ish-product-variation-display",
-          "ish-product-bundle-display",
-          "ish-line-item-edit",
-          "ish-product-inventory",
-          "ish-product-shipment",
-          "fa-icon",
-          "ish-lazy-product-add-to-order-template",
-          "ish-lazy-product-add-to-wishlist",
-          "fa-icon",
-          "ish-product-quantity-label",
-          "ish-product-quantity",
-          "ish-product-quantity",
-        ]
-      `);
+      [
+        "ish-product-image",
+        "ish-product-name",
+        "ish-product-id",
+        "ish-line-item-custom-fields",
+        "ish-product-variation-display",
+        "ish-product-bundle-display",
+        "ish-product-inventory",
+        "ish-product-shipment",
+        "fa-icon",
+        "ish-lazy-product-add-to-order-template",
+        "ish-lazy-product-add-to-wishlist",
+        "fa-icon",
+        "ish-line-item-edit",
+        "ish-product-quantity-label",
+        "ish-product-quantity",
+        "ish-product-quantity",
+      ]
+    `);
   });
 
   it('should display bundle parts for bundle products', () => {