-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/icm/834 fix ingress annotation conflict in icm web chart #835
Feature/icm/834 fix ingress annotation conflict in icm web chart #835
Conversation
Test Results 1 files 33 suites 1s ⏱️ Results for commit ebc15ba. |
Test Results7 tests 7 ✅ 0s ⏱️ Results for commit ebc15ba. ♻️ This comment has been updated with latest results. |
Target branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the ingress annotation.
It is better if we don't define ingress specific annotations directly in the helmchart, since that binds us to nginx as ingress controller and this cannot be changed easily, if decided to go for another controller
The base branch was changed.
Oh, like nearly always I selected to wrong branch. But why is no new build triggered if I change the target branch? |
Our current workflow triggers don't react on such |
PR Type
What Is the Current Behavior?
Issue Number: Closes #834
What Is the New Behavior?
Does this PR Introduce a Breaking Change?