Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/icm/834 fix ingress annotation conflict in icm web chart #835

Conversation

skiesewetter-intershop
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • CI-related changes
  • Documentation content changes
  • Application / infrastructure changes

What Is the Current Behavior?

Issue Number: Closes #834

What Is the New Behavior?

Does this PR Introduce a Breaking Change?

  • Yes
  • No

Copy link

Test Results

  1 files   33 suites   1s ⏱️
164 tests 164 ✅ 0 💤 0 ❌
165 runs  165 ✅ 0 💤 0 ❌

Results for commit ebc15ba.

Copy link

github-actions bot commented Nov 19, 2024

Test Results

7 tests   7 ✅  0s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit ebc15ba.

♻️ This comment has been updated with latest results.

@skiesewetter-intershop skiesewetter-intershop added bug Something isn't working icm Intershop ICM related helm chart changes icm-web Intershop ICM web server related helm chart changes and removed Repo labels Nov 19, 2024
@DevDavido
Copy link
Contributor

Target branch main instead of develop/icm @skiesewetter-intershop?

tvalchev2
tvalchev2 previously approved these changes Nov 19, 2024
Copy link
Contributor

@tvalchev2 tvalchev2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the ingress annotation.

It is better if we don't define ingress specific annotations directly in the helmchart, since that binds us to nginx as ingress controller and this cannot be changed easily, if decided to go for another controller

@skiesewetter-intershop skiesewetter-intershop changed the base branch from main to develop/icm November 19, 2024 12:19
@skiesewetter-intershop skiesewetter-intershop dismissed tvalchev2’s stale review November 19, 2024 12:19

The base branch was changed.

@skiesewetter-intershop
Copy link
Contributor Author

Target branch main instead of develop/icm @skiesewetter-intershop?

Oh, like nearly always I selected to wrong branch. But why is no new build triggered if I change the target branch?

@DevDavido
Copy link
Contributor

[...] But why is no new build triggered if I change the target branch?

Our current workflow triggers don't react on such edited activity type, but by default only on open, synchronize and reopened:
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

@skiesewetter-intershop skiesewetter-intershop deleted the feature/icm/834-fix-ingress-annotation-conflict-in-icm-web-chart branch November 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working icm Intershop ICM related helm chart changes icm-web Intershop ICM web server related helm chart changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICM: fix ingress annotation conflict in icm-web chart
3 participants