Skip to content

Commit

Permalink
fix(icm): fix error message about mutual exclusive databaseName/datab…
Browse files Browse the repository at this point in the history
…aseLink configuration (#884)
  • Loading branch information
smoldenhauer-ish committed Jan 9, 2025
1 parent 8e4e708 commit 8322e94
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/icm-as/templates/_environments.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ ICM-AS >= 13.0.0 requires new replication configuration
{{- fail (printf "Error: The new replication configuration 'replication.source'/'replication.targets' can be only used with ICM-AS 12.2.0 and newer, currently used '%s'." $icmApplicationServerImageSemanticVersion) -}}
{{- end -}}
{{- if and ($hasNewReplicationConfiguration) (hasKey .Values.replication.source "databaseLink") (hasKey .Values.replication.source "databaseName") -}}
{{- fail "Error: Either mutual exclusive 'replication.source.databaseUser' or 'replication.source.databaseLink' have to be configured, but not both." -}}
{{- fail "Error: Either mutual exclusive 'replication.source.databaseName' or 'replication.source.databaseLink' have to be configured, but not both." -}}
{{- end -}}
{{- if and (or (not $hasIcmApplicationServerImageSemanticVersion) $hasNewReplicationConfigurationSupport) $hasNewReplicationConfiguration }}
{{- $replicationSystemIDs := keys .Values.replication.targets | sortAlpha -}}
Expand Down
2 changes: 1 addition & 1 deletion charts/icm-as/tests/replication_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ tests:
template: templates/as-deployment.yaml
asserts:
- failedTemplate:
errorMessage: "Error: Either mutual exclusive 'replication.source.databaseUser' or 'replication.source.databaseLink' have to be configured, but not both."
errorMessage: "Error: Either mutual exclusive 'replication.source.databaseName' or 'replication.source.databaseLink' have to be configured, but not both."

- it: as-deployment fails with invalid replication target key
release:
Expand Down
2 changes: 1 addition & 1 deletion charts/icm-as/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ replication:
# source:
# the external URL of the webServer/proxy/ingress e.g. https://icm-web-edit-wa:443
# webserverUrl: <sourceExternalUrl>
# either mutual exclusive databaseUser or databaseLink have to be configured
# either mutual exclusive databaseName or databaseLink have to be configured
# databaseLink: <sourceDatabaseLink>
# databaseUser: <sourceDatabaseUser>
# databaseName: <sourceDatabaseName>
Expand Down

0 comments on commit 8322e94

Please sign in to comment.