Skip to content

Commit

Permalink
fix: fix ingress annotation conflict in icm-web chart (#834)
Browse files Browse the repository at this point in the history
  • Loading branch information
skiesewetter-intershop authored Nov 21, 2024
1 parent 5f3f7a7 commit 68d0ca3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 51 deletions.
47 changes: 0 additions & 47 deletions charts/icm-web/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,51 +42,4 @@ spec:
name: http
{{- end }}
{{- end }}
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}-internal-pages-only
labels:
app.kubernetes.io/name: {{ $fullName }} # Use shared name for the name label of the icm-web ingresses
helm.sh/chart: {{ include "icm-web.chart" . }}
app.kubernetes.io/instance: {{ $fullName }}-internal-pages-only # unique ingress identifier
app.kubernetes.io/managed-by: {{ .Release.Service }}
annotations:
nginx.ingress.kubernetes.io/real-ip-header: "X-Forwarded-For"
# Allow access to internal pages from Intershop network addresses and from loopback addresses of the local host container
# Can be extended by additional IPs
{{- $defaultAllowedIPs := list "127.0.0.0/8,195.110.61.246" }}
{{- $additionalAllowedIPs := compact (.Values.ingress.accessInternalWebAdapterPagesAllowIPs | default (list "")) }}
nginx.ingress.kubernetes.io/whitelist-source-range: {{ join "," (concat $defaultAllowedIPs $additionalAllowedIPs) | quote }}
{{- with .Values.ingress.annotations }}
{{ toYaml . | indent 4 }}
{{- end }}
spec:
{{- if .Values.ingress.className }}
ingressClassName: {{ .Values.ingress.className }}
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{- range .Values.ingress.tls }}
- hosts:
{{- range .hosts }}
- {{ . | quote }}
{{- end }}
secretName: {{ .secretName }}
{{- end }}
{{- end }}
rules:
{{- range .Values.ingress.hosts }}
- host: {{ .host | quote }}
http:
paths:
- path: /INTERSHOP/wastatistics
pathType: Exact
backend:
service:
name: {{ $fullName }}-wa
port:
name: http
{{- end }}
{{- end }}
4 changes: 0 additions & 4 deletions charts/icm-web/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@ ingress:
# - secretName: chart-example-tls
# hosts:
# - chart-example.local
# define list of IPs which are allowed to access internal pages of the webadapter service (e.g. "wastatistics")
# Intershop network addresses and loopback addresses of the local host container are already permitted by default
# accessInternalWebAdapterPagesAllowIPs:
# - 10.0.0.0/8

nameOverride: ""
fullnameOverride: ""
Expand Down

0 comments on commit 68d0ca3

Please sign in to comment.