-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[_]: feature/Switch to argon2 #242
base: master
Are you sure you want to change the base?
Conversation
Quality Gate failedFailed conditions |
import { constants } from '../../services/AppService'; | ||
import errorService from '../../services/ErrorService'; | ||
import AesUtils from '../aesUtils'; | ||
|
||
const password = constants.CRYPTO_SECRET || ''; // Force env var loading | ||
|
||
/** | ||
* Argon2id parameters taken from RFC9106 (variant for memory-constrained environments) | ||
* * @constant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think two ** here is a typo
@@ -56,32 +62,6 @@ export function decryptTextWithKey(encryptedText: string, keyToDecrypt: string): | |||
} | |||
} | |||
|
|||
export function probabilisticEncryption(content: string): string | null { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those functions are not used, right?
@@ -78,6 +78,7 @@ | |||
"expo-status-bar": "~1.11.1", | |||
"expo-system-ui": "~2.9.4", | |||
"expo-updates": "~0.24.13", | |||
"hash-wasm": "^4.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasm works or do we need a kotlin lib?
let changedPasswordNewToken; | ||
let changedPasswordToken; | ||
if (!salt.startsWith('argon2id$')) { | ||
const changePasswordResponse = await this.doChangePassword({ password: password, newPassword: password }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here it works, right? I think for drive-web I had to copy-paste some steps only
@@ -75,7 +75,7 @@ class DriveLocalDB { | |||
} | |||
|
|||
public async saveFolderContent( | |||
folderRecordData: { id: number; parentId: number; name: string; updatedAt: string }, | |||
folderRecordData: { id: number; parentId: number; name: string; updatedAt: Date }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is from sdk update, no?
@@ -4118,6 +4111,15 @@ axios@^0.27.2: | |||
follow-redirects "^1.14.9" | |||
form-data "^4.0.0" | |||
|
|||
axios@^0.28.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update it?
@@ -13167,6 +13179,11 @@ [email protected]: | |||
resolved "https://registry.yarnpkg.com/utils-merge/-/utils-merge-1.0.1.tgz#9f95710f50a267947b2ccc124741c1028427e713" | |||
integrity sha512-pMZTvIkT1d+TFGvDOqodOclx0QWkkgi6Tdoa8gC8ffGAAqz9pzPTZWAybbsHHoED/ztMtkv/VoYTYyShUn81hA== | |||
|
|||
uuid@^11.0.2: | |||
version "11.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update it?
Related Pull Requests