Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dex-general and dex-stable rpc defs #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregdhill
Copy link
Member

Signed-off-by: Gregory Hill [email protected]

"params": [
{
"name": "supply",
"type": "AssetBalance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this crash serde?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and I think not, although I'm not sure if I'm missing something or if this was indeed fixed in serde

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw many of the rpcs using FixedU128 would have the same issue

Copy link
Member

@sander2 sander2 Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw many of the rpcs using FixedU128 would have the same issue

That's not true, FixedU128 has a customSerialize implementation that serializes as string (similarly to our balance wrapper)

Copy link
Member

@sander2 sander2 Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you tested then I guess they must have fixed it upstream. Edit: it seems you just need the arbitrary_precision feature. We don't explicitly enable it but maybe one of our dependencies does serde-rs/json#548 . Edit 2: cargo tree -e features does not show the arbitrary_precision feature being enabled..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants