Merge pull request #86 from dawagner/dead-code-removal

Dead code removal These methods weren't used by anyone. This PR helps closing the coverage gap for #85.
intel · Apr 13, 2015 · 6d605e3 · 6d605e3
2 parents c918493 + 8b18043
commit 6d605e3
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 31 deletions.
diff --git a/parameter/Element.cpp b/parameter/Element.cpp
@@ -401,15 +401,6 @@ const CElement* CElement::getChild(size_t uiIndex) const
     return _childArray[uiIndex];
 }
 
-CElement* CElement::getLastChild()
-{
-    size_t uiNbChildren = getNbChildren();
-
-    assert(uiNbChildren);
-
-    return _childArray[uiNbChildren - 1];
-}
-
 CElement* CElement::createChild(const CXmlElement& childElement,
                                 CXmlSerializingContext& serializingContext)
 {
@@ -600,20 +591,6 @@ bool CElement::isDescendantOf(const CElement* pCandidateAscendant) const
     return _pParent->isDescendantOf(pCandidateAscendant);
 }
 
-CElement* CElement::findAscendantOfKind(const string& strKind)
-{
-    if (!_pParent) {
-
-        return NULL;
-    }
-
-    if (_pParent->getKind() == strKind) {
-
-        return _pParent;
-    }
-    return _pParent->findAscendantOfKind(strKind);
-}
-
 CElement* CElement::findChild(const string& strName)
 {
     uint32_t uiIndex;

diff --git a/parameter/Element.h b/parameter/Element.h
@@ -151,9 +151,7 @@ class CElement : public IXmlSink, public IXmlSource
     static void appendTitle(std::string& strTo, const std::string& strTitle);
 
     // Hierarchy
-    CElement* getLastChild();
     CElement* getParent();
-    CElement* findAscendantOfKind(const std::string& strKind);
 
     /**
      * Creates a child CElement from a child XML Element

diff --git a/xmlserializer/XmlElement.cpp b/xmlserializer/XmlElement.cpp
@@ -238,11 +238,6 @@ void CXmlElement::setTextContent(const string& strContent)
     xmlAddChild(_pXmlElement, xmlNewText(BAD_CAST strContent.c_str()));
 }
 
-void CXmlElement::setComment(const string& strComment)
-{
-    xmlAddChild(_pXmlElement, xmlNewComment(BAD_CAST strComment.c_str()));
-}
-
 // Child creation
 void CXmlElement::createChild(CXmlElement& childElement, const string& strType)
 {

diff --git a/xmlserializer/XmlElement.h b/xmlserializer/XmlElement.h
@@ -69,7 +69,6 @@ class CXmlElement
     void setAttributeString(const std::string& strAttributeName, const std::string& strValue);
     void setNameAttribute(const std::string& strValue);
     void setTextContent(const std::string& strContent);
-    void setComment(const std::string& strComment);
     void setAttributeInteger(const std::string& strAttributeName, uint32_t uiValue);
     /**
       * Set attribute with signed integer