allow cliloader to proceed in more cases #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the child thread to replace functions cannot be created, we should still continue, since loading the right OpenCL.dll in the child process is usually enough to perform interception.
|
Marking as draft for a bit more review and testing. |
|
This was not as helpful as I was initially hoping it would be, but it doesn't seem to be hurting anything either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
On Windows, if the child thread to replace functions cannot be created, we should still continue, since loading the intercept layer OpenCL.dll in the child process is usually enough to successfully intercept OpenCL calls.
Testing Done
Forced the child thread to fail creation. Observed that cliloader could proceed, and that interception was successful.