Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Improvements Targeting Windows #136

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Improvements Targeting Windows #136

merged 8 commits into from
Feb 22, 2024

Conversation

DDEle
Copy link
Contributor

@DDEle DDEle commented Feb 22, 2024

Type of Change: features

API not changed

Description

(actually they are non-mha changes on the mha-avx2 branch)

How has this PR been tested?

Dependency Change?

No

Copy link
Contributor

@zhewang1-intc zhewang1-intc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except minor comments

CMakeLists.txt Outdated Show resolved Hide resolved
@airMeng
Copy link
Contributor

airMeng commented Feb 22, 2024

after #135 merged, you can rebase and trigger CI again

@airMeng airMeng merged commit 4642395 into intel:main Feb 22, 2024
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants