Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_scan_layouts[True-1-src_layout10-64-32] on LTS driver #2790

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

anmyachev
Copy link
Contributor

No description provided.

@anmyachev anmyachev linked an issue Nov 21, 2024 that may be closed by this pull request
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
Copy link
Contributor Author

@whitneywhtsang this test produces many of the same constants, such as:

@assertFunc_447 = internal addrspace(1) constant [8 x i8] c"unknown\00"
@assertFile_447 = internal addrspace(1) constant [87 x i8] c".../pytest-0/test_scan_layouts_True_1_src_l0/test_scan_layouts.ttgir\00"
@assertMessage_447 = internal addrspace(1) constant [18 x i8] c"overflow detected\00"

Does it make sense to compare the contents of constants before adding them to reduce their total number? If so, I would like to try to implement it.

@whitneywhtsang
Copy link
Contributor

@whitneywhtsang this test produces many of the same constants, such as:

@assertFunc_447 = internal addrspace(1) constant [8 x i8] c"unknown\00"
@assertFile_447 = internal addrspace(1) constant [87 x i8] c".../pytest-0/test_scan_layouts_True_1_src_l0/test_scan_layouts.ttgir\00"
@assertMessage_447 = internal addrspace(1) constant [18 x i8] c"overflow detected\00"

Does it make sense to compare the contents of constants before adding them to reduce their total number? If so, I would like to try to implement it.

Is it related to the test failure? Is it unique to Intel backend?

@anmyachev
Copy link
Contributor Author

Is it related to the test failure?

Not directly, I just noticed that there were a lot of identical objects.

Is it unique to Intel backend?

The code is similar to the one used for the NVIDIA backend, I suppose so, but I haven't run it on their hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test_scan_layouts[True-1-src_layout10-64-32] on LTS driver
2 participants