-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default benchmark mode to upstream PyTorch #2298
Conversation
Signed-off-by: Anatoly Myachev <[email protected]>
Let's move on. This change can be easily rolled back if necessary. |
@anmyachev Should the ratio diff be recalculated for FA as well? |
Most likely due to different time spent on the host, in the case of Triton there is more Python code, which is slower than C++. @whitneywhtsang since GEMM on Triton it became worse than planned, I suppose it is worth rolling back this change? Or is this an acceptable change? UPD: about overhead in Triton: triton-lang/triton#3166 |
We should report the performance number with IPEX on by default because without IPEX the timing taken by upstream PyTorch is not precise (not just the kernel time). IMHO we should revert this change. |
This reverts commit 782aecf.
…2342) Address #2298 (comment). This reverts commit 782aecf. CI status: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11034669496
Current state (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10950264922 vs https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10949253321):
triton geomean diff: 2%, xetla geomean diff: 3%, ratio geomean diff: 2%.Correct numbers are: triton geomean diff: -2.3%, xetla geomean diff: -4%, ratio (triton/xetla) geomean diff: 1.7%triton geomean diff: 2%, xetla geomean diff: 2%, ratio geomean diff: 4%. Correct numbers are: triton geomean diff: -4.1%, xetla geomean diff: -2.7%, ratio (triton/xetla) geomean diff: -1.4%