Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactored acceptance test automation #2476

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Nov 25, 2024

Resolves #2425


Before the change?

The automated GH Actions integration tests are broken and highly complex.

After the change?

The GH Actions integration tests work and have been simplified to run all relevant acceptance tests for github.com.

The logic to trigger the tests is to either manually run them or to add a label (acctest?) to a PR. Anonymous tests should run as is but there should be dotcom and ghes environments protecting the relevant secret and the environment should require approval.

Outstanding Tasks

  • Update contributing docs
  • Add acctest repo label
  • Add dotcom repo environment
  • Add ghes repo environment
  • Configure non-anonymous test environment
    • Test user (owns)
      • Token
      • Free org
        • Repo
        • Template repo
        • Secret
        • App installation
      • Team org
        • Repo
        • Template repo
        • Secret
        • App installation
      • Enterprise
        • Enterprise org
          • Repo
          • Template repo
          • Secret
          • App installation
    • Org user
      • Member of free org
      • Member of team org
      • Member of enterprise org
    • External user 1
      • Token
    • External user 2

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell
Copy link
Contributor Author

@kfcampbell I've got the anonymous tests running correctly after refactoring the acceptance tests and defining all of the inputs and when they should run. I'm now at the point where I need access to test users and organisations, I've updated the description above to cover what's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINT]: Add GitHub Actions workflow for integration testing
1 participant