Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not update/create rulesets on archived repository #2460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scadu
Copy link

@scadu scadu commented Nov 13, 2024

At the moment, provider would attempt to update github_repository_ruleset on archived repository resulting in 403 from GitHub API. Provider should not attempt updating this attribute when repository is archived (read-only).

Resolves #2459


Before the change?

  • Provider attempts to update github_repository_ruleset on archived (read-only) repository.

After the change?

  • Provider skips updating github_repository_ruleset on archived repository.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

scadu and others added 2 commits November 13, 2024 12:36
At the moment, provider would attempt to update `github_repository_ruleset` on archived repository resulting in 403 from GitHub API.
Provider should not attempt updating this attribute when repository is archived (read-only).
@scadu scadu marked this pull request as ready for review November 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: updating `github_repository_ruleset
1 participant