BENB potentiometer centering #128

benblaise-intech · 2024-11-25T15:46:50Z

No description provided.

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.20 (6.85 -> 6.65)

Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.02 (6.85 -> 6.88)

Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.03 (6.85 -> 6.89)

Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.03 (6.85 -> 6.89)

Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.06 (6.64 -> 6.69)

Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

SukuWc

Good general implementation, fits architecture well!
Todo: Please implement the changes regarding code style!

SukuWc · 2024-11-26T13:42:18Z

grid_common/grid_cal.c

+  cal->center = malloc(cal->length * sizeof(uint16_t));
+  cal->enable = malloc(cal->length * sizeof(uint8_t));
+
+  const uint16_t half_value = cal->maximum >> 1;


use cal->maximum/2 for readability

SukuWc · 2024-11-26T13:45:33Z

grid_common/grid_cal.c

+  return cal->value[channel];
+}
+
+uint16_t restrict_to_range(uint16_t x, uint16_t min, uint16_t max) {


tag internal methods with the static keyword

SukuWc · 2024-11-26T13:59:24Z

grid_common/grid_cal.c

+
+  cal->maximum = 1 << cal->resolution;
+
+  cal->value = malloc(cal->length * sizeof(uint16_t));


cast result of malloc to uint16_t* for CPP compatibility

SukuWc · 2024-11-26T14:02:24Z

grid_common/grid_cal.c

+
+  if (!cal->enable[channel]) {
+    return 1;
+  }


only implement return status if status is actually checked. Otherwise stick to void.
if you decide to implement and check status, make sure it's type is int.

SukuWc · 2024-11-26T14:06:09Z

grid_common/grid_protocol.h

@@ -393,6 +393,14 @@
 #define GRID_LUA_FNC_G_ELEMENT_COUNT_fnptr l_grid_element_count
 #define GRID_LUA_FNC_G_ELEMENT_COUNT_usage "element_count(void) Returns the number of elements on the current module."

+#define GRID_LUA_FNC_G_POTMETER_CALIBRATION_GET_short "gpcg"
+#define GRID_LUA_FNC_G_POTMETER_CALIBRATION_GET_human "potmeter_calibration_get"
+#define GRID_LUA_FNC_G_POTMETER_CALIBRATION_GET_fnptr l_grid_potmeter_calibration_get


Always add usage explaining string (similar to #define GRID_LUA_FNC_G_ELEMENT_COUNT_usage) for use in editor UX

will add in a commit after 9d39ceb

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.22 (6.64 -> 6.42)

Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

grid_common/grid_lua_api.c

codescene-delta-analysis · 2024-11-26T15:46:52Z

grid_common/grid_lua_api.c

@@ -1590,6 +1590,109 @@
  return 1;
 }

+/*static*/ int l_grid_potmeter_calibration_get(lua_State* L) {


ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.06 to 5.20, threshold = 4

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.22 (6.64 -> 6.42)

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.22 (6.64 -> 6.42)

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.22 (6.64 -> 6.42)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.22 (6.64 -> 6.41)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Absence of Expected Change Pattern

grid-fw/grid_esp/components/grid_esp32_module_pbf4/grid_esp32_module_pbf4.c is usually changed with: grid-fw/grid_esp/components/grid_esp32_module_bu16/grid_esp32_module_bu16.c

codescene-delta-analysis · 2024-11-27T14:14:48Z

grid_common/grid_cal.c

+static int32_t inverse_error_centering(int32_t a, int32_t b, float x, float c, uint8_t iter) {
+
+  for (uint8_t i = 0; i < iter; ++i) {
+
+    if (x < c) {
+      b = (a + b) / 2;
+      x = x / c;
+    } else {
+      a = (a + b) / 2;
+      x = (x - c) / (1.0 - c);
+    }
+  }
+
+  return lerp(a, b, x);
+}


❌ New issue: Excess Number of Function Arguments
inverse_error_centering has 5 arguments, threshold = 4

_Suppress

ben added 2 commits November 25, 2024 16:41

BENB volatile potentiometer centering for PBF4

12859a9

BENB format.sh

ee51637

benblaise-intech requested a review from SukuWc November 25, 2024 15:46

This comment was marked as outdated.

Sign in to view

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

BENB potentiometer calibration abstraction

a366623

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

BENB format.sh

d6609e1

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

BENB fix d51 build

306d864

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

SukuWc marked this pull request as ready for review November 26, 2024 13:37

Merge branch 'master' into BENB-potentiometer-centering

bfcab66

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

SukuWc reviewed Nov 26, 2024

View reviewed changes

BENB return status for potentiometer calibration

9d39ceb

codescene-delta-analysis bot reviewed Nov 26, 2024

View reviewed changes

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

BENB calibration sign checks and usage descriptions

b5a1b57

codescene-delta-analysis bot approved these changes Nov 26, 2024

View reviewed changes

ben added 2 commits November 27, 2024 15:13

BENB iterative single-point offset calibration

c7eaf7b

BENB format.sh

4803634

codescene-delta-analysis bot approved these changes Nov 27, 2024

View reviewed changes

SukuWc merged commit d7af57b into master Nov 28, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BENB potentiometer centering #128

BENB potentiometer centering #128

benblaise-intech commented Nov 25, 2024

This comment was marked as outdated.

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

SukuWc left a comment

SukuWc Nov 26, 2024

SukuWc Nov 26, 2024

SukuWc Nov 26, 2024

SukuWc Nov 26, 2024

SukuWc Nov 26, 2024

benblaise-intech Nov 26, 2024

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot Nov 26, 2024

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot left a comment

codescene-delta-analysis bot Nov 27, 2024


		cal->maximum = 1 << cal->resolution;

		cal->value = malloc(cal->length * sizeof(uint16_t));

BENB potentiometer centering #128

BENB potentiometer centering #128

Conversation

benblaise-intech commented Nov 25, 2024

This comment was marked as outdated.

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

SukuWc left a comment

Choose a reason for hiding this comment

SukuWc Nov 26, 2024

Choose a reason for hiding this comment

SukuWc Nov 26, 2024

Choose a reason for hiding this comment

SukuWc Nov 26, 2024

Choose a reason for hiding this comment

SukuWc Nov 26, 2024

Choose a reason for hiding this comment

SukuWc Nov 26, 2024

Choose a reason for hiding this comment

benblaise-intech Nov 26, 2024

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot Nov 26, 2024

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Absence of Expected Change Pattern

codescene-delta-analysis bot Nov 27, 2024

Choose a reason for hiding this comment