more yoda / fix test / changelog

int-brain-lab · Oct 4, 2024 · 8e4cc6b · 8e4cc6b
1 parent 66051a9
commit 8e4cc6b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 Changelog
 =========
 
+8.24.2
+------
+* fix: create the `raw_ephys_data` folder even if there are no probes (when running behavior sessions on ephys rig)
+
 8.24.2
 ------
 * make Frame2TTL validation more robust

diff --git a/iblrig/test/test_hardware_mixins.py b/iblrig/test/test_hardware_mixins.py
@@ -109,12 +109,12 @@ def test_rotary_encoder_mixin(self):
             'RotaryEncoder1_3',
             'RotaryEncoder1_4',
         ]
-        assert {
+        assert session.device_rotary_encoder.THRESHOLD_EVENTS == {
             -35: 'RotaryEncoder1_1',
             35: 'RotaryEncoder1_2',
             -2: 'RotaryEncoder1_3',
             2: 'RotaryEncoder1_4',
-        } == session.device_rotary_encoder.THRESHOLD_EVENTS
+        }
         with self.assertRaises(ValueError):
             RotaryEncoderMixin.start_mixin_rotary_encoder(session)
 

diff --git a/iblrig/test/test_transfers.py b/iblrig/test/test_transfers.py
@@ -232,7 +232,7 @@ def test_behavior_ephys_video_copy(self):
         self.assertEqual(set(final_experiment_description['sync'].keys()), {'nidq'})
 
     # Requires recent change to ibllib test fixture code supporting no probe ephys recording files
-    @unittest.skipIf(version.parse(ibllib.__version__) < version.parse('2.39'))
+    @unittest.skipIf(version.parse(ibllib.__version__) < version.parse('2.39'), 'ibllib < 2.39')
     def test_ephys_no_probe(self):
         """Test copying a session at ephys rig when no probes were used (DAQ only)."""
         # First create a behavior session