-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting up CI for the repo #33
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good if the CI is running - which it seems to do.
Just a few opinions:
- Use actions/setup-python@v5
- Caching makes GH workflows a lot snappier as you don't have to set up the environment from scratch each time, see https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows
- I personally use PDM as a package manager - it simplifies a few things about the GH workflow (especially when it comes to publishing at some point) - happy to walk you through it if you're interested
- it might be useful to save the versions of dependencies as a workflow artifact (
requirements-frozen.txt
) - how about adding coverage? you could use the
pytest-cov
plugin for that ...
No description provided.