Merge pull request #39 from int-brain-lab/wf_extract_fix

Wf extract fix
int-brain-lab · Aug 20, 2024 · 913610e · 913610e
2 parents 3146d40 + 5380377
commit 913610e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/release_notes.md b/release_notes.md
@@ -1,5 +1,8 @@
 # 1.2
 
+## 1.2.1 2024-08-20
+- bugfix waveform extraction: fix logic when channel labels is not None
+
 ## 1.2.0 2024-08-01
 - Adds `ibldsp.waveform_extraction.WaveformsLoader`, an interface for waveforms extracted by `extract_wfs_cbin`.
 

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 
 setuptools.setup(
     name="ibl-neuropixel",
-    version="1.2.0",
+    version="1.2.1",
     author="The International Brain Laboratory",
     description="Collection of tools for Neuropixel 1.0 and 2.0 probes data",
     long_description=long_description,

diff --git a/src/ibldsp/waveform_extraction.py b/src/ibldsp/waveform_extraction.py
@@ -350,8 +350,8 @@ def extract_wfs_cbin(
     if channel_labels is None and "bad_channel_interpolation" in preprocess_steps:
         logger.info("Running channel detection")
         channel_labels = _get_channel_labels(sr)
-    else:
-        channel_labels = channel_labels or np.zeros(sr.nc - sr.nsync)
+    elif channel_labels is None:
+        channel_labels = np.zeros(sr.nc - sr.nsync)
 
     nwf = len(wf_flat)
     nu = unit_ids.shape[0]