Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip redundant Arc allocation on hot pahs #3

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tyranron
Copy link
Member

Requires tikv/rust-prometheus#472

Synopsis

There are some redundant Arc allocations on hot paths due to upstream APIs.

Solution

Eliminate these allocations by re-using the inner Arc of metrics from prometheus crate.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::performance Related to performance k::toolchain Related to project toolchain labels Dec 21, 2022
@tyranron tyranron self-assigned this Dec 21, 2022
@tyranron tyranron added this to the 0.3.1 milestone Dec 21, 2022
@tyranron tyranron removed this from the 0.3.1 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::performance Related to performance k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant