Fix RTC_DISABLE_PROXY_TRACE_EVENTS define usage
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdokimovs
added
enhancement
FCMFix `RTC_DISABLE_PROXY_TRACE_EVENTS` define usage (#109)
Additionally:
- fix arguments names in `RTCYUVHelper` |
tyranron
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In instrumentisto/medea-flutter-webrtc#162 it was discovered that currently
libwebrtcheaders are not compiling on desktop platforms, because ofperfettousage inpc/proxy.hfile.libwebrtchasRTC_DISABLE_PROXY_TRACE_EVENTSdefine which disables tracing in this file, but it doesn't disable include of files required for this tracing.So this PR hides
includefor thetrace_event.hunderRTC_DISABLE_PROXY_TRACE_EVENTSdefine.