Skip to content

Commit

Permalink
Upgrade to 126.0.6478.182-r1 version (#111)
Browse files Browse the repository at this point in the history
- support additional `REVISION` number for versioning

Co-authored-by: Kai Ren <[email protected]>
  • Loading branch information
evdokimovs and tyranron authored Jul 19, 2024
1 parent 9281496 commit 10dbf50
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 9 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ jobs:
- name: Verify release version matches VERSION file
run: |
test "${{ steps.release.outputs.version }}" \
== "$(grep 'WEBRTC_VERSION=' VERSION | cut -d '=' -f2 | tr -d '\n')"
if: ${{ !contains(steps.release.outputs.version, '-') }}
== "$(grep 'WEBRTC_VERSION=' VERSION | cut -d '=' -f2 | tr -d '\n')$(grep -e '^REVISION=.*$' VERSION | cut -d '=' -f2 | sed -e 's/^/-r/' | tr -d '\n')"
- uses: actions/download-artifact@v4
with:
Expand Down Expand Up @@ -270,4 +269,3 @@ jobs:
package/libwebrtc-*.zip
package/libwebrtc-*.zip.sha256sum
fail_on_unmatched_files: true
prerelease: ${{ contains(steps.release.outputs.version, '-') }}
7 changes: 7 additions & 0 deletions VERSION
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ WEBRTC_VERSION=126.0.6478.182
# https://chromium.googlesource.com/chromium/src/+/refs/tags/<WEBRTC_VERSION>/DEPS
WEBRTC_COMMIT=a18e38fed2307edd6382760213fa3ddf199fa181

# Additional revision of the `WEBRTC_VERSION` added as `-rN` suffix to it, and
# tracking additional changes applied on top of it.
# Required for being able to release new versions without waiting for the
# `WEBRTC_VERSION` bump. If absent or is commented out, then no `REVISION` is
# added to the `WEBRTC_VERSION`.
REVISION=1

PACKAGE_NAMES= \
linux-arm64 \
linux-x64 \
Expand Down
4 changes: 2 additions & 2 deletions instrumentisto-libwebrtc-bin.podspec
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
Pod::Spec.new do |spec|
spec.name = "instrumentisto-libwebrtc-bin"
spec.version = "126.0.6478.182"
spec.version = "126.0.6478.182-r1"
spec.summary = "Pre-compiled `libwebrtc` library for Darwin used by Medea Flutter-WebRTC."

spec.homepage = "https://github.com/instrumentisto/libwebrtc-bin"
spec.license = { :type => 'BSD', :file => 'WebRTC.xcframework/LICENSE.md' }
spec.author = { 'Instrumentisto Team' => '[email protected]' }
spec.ios.deployment_target = '10.0'

spec.source = { :http => "https://github.com/instrumentisto/libwebrtc-bin/releases/download/126.0.6478.182/libwebrtc-ios.zip" }
spec.source = { :http => "https://github.com/instrumentisto/libwebrtc-bin/releases/download/126.0.6478.182-r1/libwebrtc-ios.zip" }
spec.vendored_frameworks = "WebRTC.xcframework"

spec.pod_target_xcconfig = {
Expand Down
16 changes: 12 additions & 4 deletions upgrade-ver.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,22 @@ fi
sed -i.bk -e "s/^WEBRTC_VERSION=.*$/WEBRTC_VERSION=$newVersion/g" \
-e "s/^WEBRTC_COMMIT=.*$/WEBRTC_COMMIT=$newCommit/g" \
./VERSION
sed -i.bk -e "s/spec\.version =.*$/spec.version = \"$newVersion\"/g" \
-e "s/\/download\/.*\//\/download\/$newVersion\//g" \

if ! cmp -s ./VERSION ./VERSION.bk; then
sed -i.bk -e "s/^REVISION=/#REVISION=/g" \
./VERSION
fi
revision=$(grep -e '^REVISION=.*$' ./VERSION | cut -d '=' -f2 \
| sed -e 's/^/-r/')

sed -i.bk -e "s/spec\.version =.*$/spec.version = \"$newVersion$revision\"/g" \
-e "s/\/download\/.*\//\/download\/$newVersion$revision\//g" \
./instrumentisto-libwebrtc-bin.podspec

echo "version=$newVersion"
echo "version=$newVersion$revision"
echo "commit=$newCommit"

if [ ! -z "$GITHUB_OUTPUT" ]; then
echo "version=$newVersion" >> $GITHUB_OUTPUT
echo "version=$newVersion$revision" >> $GITHUB_OUTPUT
echo "commit=$newCommit" >> $GITHUB_OUTPUT
fi

0 comments on commit 10dbf50

Please sign in to comment.