fix(ui-date-time-input,ui-form-field): make DateTimeInput compatible … #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
approved these changes
Dec 13, 2024
…with the new error format
balzss
force-pushed
the
fix/datetimeinput-required-error
branch
from
cd32eaf to
c0e9a50
Compare
fixed. it was a missing |
HerrTopi
approved these changes
Dec 18, 2024
matyasf
added a commit
that referenced
this pull request
Dec 19, 2024
…with the new error format Backport of INSTUI-4405 from the v10 branch Github PR #1826 TEST PLAN: - check the datetimeinput examples in the error forms guide - setting the isRequired prop should display two separate asterisks for each field - when required and displaying an error, the asterisks should turn red - the errors should be displayed under the input field like it was a single field and not a group
matyasf
added a commit
that referenced
this pull request
Dec 19, 2024
…with the new error format Backport of INSTUI-4405 from the v10 branch Github PR #1826 TEST PLAN: - check the datetimeinput examples in the error forms guide - setting the isRequired prop should display two separate asterisks for each field - when required and displaying an error, the asterisks should turn red - the errors should be displayed under the input field like it was a single field and not a group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with the new error format
INSTUI-4405
test plan:
isRequiredprop should display two separate asterisks for each field