feat(ui-calendar,ui-date-input): update DateInput2 api, add placeholder hint #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
requested changes
Sep 26, 2024
Comment on lines
+148
to
+171
| // this is needed for locales that doesn't use the latin script for numbers e.g.: arabic | ||
| const yearNumber = Number( | ||
| this.state.visibleMonth | ||
| .clone() | ||
| .locale('en') | ||
| .subtract({ months: 1 }) | ||
| .format('YYYY') | ||
| ) | ||
| return ( | ||
| !this.props.withYearPicker || | ||
| (this.props.withYearPicker && | ||
| Number( | ||
| this.state.visibleMonth.clone().subtract({ months: 1 }).format('YYYY') | ||
| ) >= this.props.withYearPicker.startYear) | ||
| yearNumber >= this.props.withYearPicker.startYear) | ||
| ) | ||
| } | ||
|
|
||
| get hasNextMonth() { | ||
| // this is needed for locales that doesn't use the latin script for numbers e.g.: arabic | ||
| const yearNumber = Number( | ||
| this.state.visibleMonth | ||
| .clone() | ||
| .locale('en') | ||
| .add({ months: 1 }) | ||
| .format('YYYY') | ||
| ) |
There was a problem hiding this comment.
could you write a unit test for these?
There was a problem hiding this comment.
is it ok if it's added to the separate pr with all the other unit tests for dateinput2?
matyasf
approved these changes
Sep 30, 2024
HerrTopi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v10 port of #1640