test(ui-alerts): migrate old Alert tests #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToMESSKa
force-pushed
the
INSTUI-4187_convert_ui-alerts_to_the_new_test_format
branch
from
74388e5 to
1bc95eb
Compare
|
matyasf
approved these changes
Aug 30, 2024
joyenjoyer
reviewed
Aug 30, 2024
| }) | ||
|
|
||
| it('should add alert text to aria live region, when present', async () => { | ||
| const liver = document.getElementById('_alertLiveRegion')! |
There was a problem hiding this comment.
Please rename this to liveRegion or something else instead of an anatomical terminology. :D
Go through all the places in the code.
There was a problem hiding this comment.
I renamed liver to liveRegion everywhere
ToMESSKa
force-pushed
the
INSTUI-4187_convert_ui-alerts_to_the_new_test_format
branch
from
1bc95eb to
859c610
Compare
joyenjoyer
approved these changes
Sep 2, 2024
Closes: INSTUI-4187
ToMESSKa
force-pushed
the
INSTUI-4187_convert_ui-alerts_to_the_new_test_format
branch
from
859c610 to
42d3a94
Compare
ToMESSKa
deleted the
INSTUI-4187_convert_ui-alerts_to_the_new_test_format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4187