Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-menu): add renderLabelInfo to Menu #1650

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

joyenjoyer
Copy link
Contributor

@joyenjoyer joyenjoyer commented Aug 26, 2024

Closes: INSTUI-4192

Add renderLabelInfo - either a string or a React.Node - prop to a Menu. It should be shown near the label. Override the minWidth theme variable if the width is not enough for the renderLabelInfo content.

@joyenjoyer joyenjoyer self-assigned this Aug 26, 2024
@joyenjoyer joyenjoyer requested review from balzss and HerrTopi August 26, 2024 11:35
@joyenjoyer joyenjoyer marked this pull request as ready for review August 26, 2024 11:36
@balzss
Copy link
Contributor

balzss commented Sep 12, 2024

why have the pr actions not run for this?

@joyenjoyer
Copy link
Contributor Author

joyenjoyer commented Sep 13, 2024

why have the pr actions not run for this?

Good q. I can't remember clearly but first this might have been a draft pr but I don't see that on the pr's history.

@joyenjoyer joyenjoyer closed this Sep 16, 2024
@joyenjoyer joyenjoyer deleted the INSTUI-4192-add-render-label-info-to-menu branch September 16, 2024 10:47
@joyenjoyer joyenjoyer restored the INSTUI-4192-add-render-label-info-to-menu branch September 16, 2024 10:48
@joyenjoyer joyenjoyer reopened this Sep 16, 2024
@joyenjoyer joyenjoyer force-pushed the INSTUI-4192-add-render-label-info-to-menu branch from a9a50af to 82c73ad Compare September 16, 2024 12:03
Copy link

github-actions bot commented Sep 16, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-17 14:30 UTC

Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention that this prop only works for submenus, but otherwise looks good and works great

@joyenjoyer joyenjoyer force-pushed the INSTUI-4192-add-render-label-info-to-menu branch from 82c73ad to 2e5e878 Compare September 17, 2024 14:17
@joyenjoyer joyenjoyer merged commit 2bc8554 into master Sep 17, 2024
11 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-4192-add-render-label-info-to-menu branch September 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants