Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-codemods): add codemod for v10 color update #1596

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat(ui-codemods): add codemod for v10 color update #1596

merged 1 commit into from
Jul 30, 2024

Conversation

joyenjoyer
Copy link
Contributor

@joyenjoyer joyenjoyer commented Jul 23, 2024 •
edited
Loading

Closes: INSTUI-4144

You can use this command to run the test for this codemod:
npx jest /packages/ui-codemods/__tests__/updateV10Colors.test.js

@joyenjoyer joyenjoyer requested review from matyasf and balzss July 23, 2024 11:22
@joyenjoyer joyenjoyer self-assigned this Jul 23, 2024
@joyenjoyer joyenjoyer changed the title feat(ui-codemods): add codemode for v10 color update feat(ui-codemods): add codemod for v10 color update Jul 23, 2024
@joyenjoyer joyenjoyer force-pushed the INSTUI-4144-write-codemod branch 3 times, most recently from cf2c80c to 4f34566 Compare July 23, 2024 11:58
@joyenjoyer joyenjoyer changed the base branch from master to new_color_system July 23, 2024 12:04
@joyenjoyer joyenjoyer changed the base branch from new_color_system to master July 23, 2024 12:05
@joyenjoyer joyenjoyer requested a review from HerrTopi July 23, 2024 12:17
matyasf
matyasf requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. colors2.input and colors2.output are the same
  2. Can you add this v10 codemod to the Readme of ui-codemods and to the v10 upgrade guide?
  3. Some tests are failing, it seems unrelated?

packages/ui-codemods/lib/utils/updateToV10Colors.ts Outdated Show resolved Hide resolved
packages/ui-codemods/lib/utils/updateToV10Colors.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1596/
on branch gh-pages at 2024-07-30 20:21 UTC

@joyenjoyer joyenjoyer changed the base branch from master to new_color_system July 28, 2024 18:20
@joyenjoyer joyenjoyer force-pushed the INSTUI-4144-write-codemod branch from 0ed0e76 to b033ff4 Compare July 30, 2024 11:29
@github-actions GitHub Actions
Copy link

Preview URL: https://1596--preview-instui.netlify.app

@balzss balzss force-pushed the INSTUI-4144-write-codemod branch from b033ff4 to 925bf1d Compare July 30, 2024 19:18
@joyenjoyer joyenjoyer force-pushed the INSTUI-4144-write-codemod branch from 925bf1d to 297705c Compare July 30, 2024 20:10
@joyenjoyer joyenjoyer force-pushed the INSTUI-4144-write-codemod branch from 297705c to ae72864 Compare July 30, 2024 20:11
@joyenjoyer joyenjoyer merged commit 98156ea into new_color_system Jul 30, 2024
4 of 5 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-4144-write-codemod branch July 30, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf requested changes

@balzss balzss balzss approved these changes

@HerrTopi HerrTopi HerrTopi approved these changes

Assignees

@joyenjoyer joyenjoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyenjoyer @matyasf @HerrTopi @balzss