Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui-tag): migrate old Tag tests #1579

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ToMESSKa
Copy link
Contributor

Closes: INSTUI-4128

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tamas Kovacs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ToMESSKa ToMESSKa self-assigned this Jul 11, 2024
@ToMESSKa ToMESSKa requested review from matyasf and joyenjoyer July 11, 2024 13:11
Copy link

Preview URL: https://1579--preview-instui.netlify.app

@ToMESSKa ToMESSKa marked this pull request as ready for review July 15, 2024 09:15
Comment on lines +40 to +41
// View component read Component.name instead of Component.displayName
// causing [undefined] in error messages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is weird. Do we know why it happens? (it should not happen, @decorator adds the displayName to every component that has name set)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nándi said he's looking into it, but he hasn't found the cause yet. There are some other components where this problem comes up too.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4128_convert_ui-tag_to_the_new_test_format branch from 8b77a7d to ca8320e Compare July 17, 2024 10:32
@ToMESSKa ToMESSKa force-pushed the INSTUI-4128_convert_ui-tag_to_the_new_test_format branch from ca8320e to f3c864a Compare July 17, 2024 14:36
@ToMESSKa ToMESSKa merged commit 1b81b7e into master Jul 17, 2024
8 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4128_convert_ui-tag_to_the_new_test_format branch July 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants