feat(ui-date-input): improve DateInput2 api, extend docs

instructure · Sep 23, 2024 · f369604 · f369604
1 parent 4c55bc9
commit f369604
Show file tree

Hide file tree

Showing 6 changed files with 394 additions and 298 deletions.
diff --git a/.github/workflows/manual-release-from-pr.yml b/.github/workflows/manual-release-from-pr.yml
@@ -16,8 +16,6 @@ jobs:
         run: npm ci
       - name: Set up project
         run: npm run bootstrap
-      - name: Run tests
-        run: npm run test:patchset
       - name: Release to NPM
         env:
           NPM_TOKEN: ${{secrets.NPM_TOKEN}}

diff --git a/packages/ui-calendar/src/Calendar/index.tsx b/packages/ui-calendar/src/Calendar/index.tsx
@@ -166,7 +166,7 @@ class Calendar extends Component<CalendarProps, CalendarState> {
       this.state.visibleMonth
         .clone()
         .locale('en')
-        .subtract({ months: 1 })
+        .add({ months: 1 })
         .format('YYYY')
     )
     return (
@@ -318,6 +318,7 @@ class Calendar extends Component<CalendarProps, CalendarState> {
             <SimpleSelect
               width="90px"
               renderLabel=""
+              placeholder="--"
               assistiveText={withYearPicker.screenReaderLabel}
               value={visibleMonth.format('YYYY')}
               onChange={(

diff --git a/packages/ui-date-input/src/DateInput/README.md b/packages/ui-date-input/src/DateInput/README.md
@@ -2,7 +2,7 @@
 describes: DateInput
 ---
 
-> **Important:** You can now use are updated version [`DateInput2`](/#DateInput2) which is easier to configure for developers, has a better UX, better accessibility features and a year picker. We recommend using that instead of `DateInput` which will be deprecated in the future.
+> *Note:* you can now try the updated (but still experimental) [`DateInput2`](/#DateInput2) which is easier to configure for developers, has a better UX, better accessibility features and a year picker. We recommend using that instead of `DateInput` which will be deprecated in the future.
 
 The `DateInput` component provides a visual interface for inputting date data.