fix(ui-checkbox,ui-spinner): remove hover highlight from disabled che…

…ckbox Closes: INSTUI-3894
instructure · Oct 17, 2023 · 3fe755f · 3fe755f
1 parent 065d3e7
commit 3fe755f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/ui-checkbox/src/Checkbox/index.tsx b/packages/ui-checkbox/src/Checkbox/index.tsx
@@ -156,9 +156,10 @@ class Checkbox extends Component<CheckboxProps, CheckboxState> {
   }
 
   handleMouseOver = () => {
-    this.setState({
-      hovered: true
-    })
+    !this.props.disabled &&
+      this.setState({
+        hovered: true
+      })
   }
 
   handleMouseOut = () => {

diff --git a/packages/ui-spinner/src/Spinner/__new-tests__/Spinner.test.tsx b/packages/ui-spinner/src/Spinner/__new-tests__/Spinner.test.tsx
@@ -30,7 +30,9 @@ import Spinner from '../index'
 describe('<Spinner />', () => {
   describe('with the delay prop', () => {
     it('should delay rendering', async () => {
-      const { container } = render(<Spinner delay={300} />)
+      const { container } = render(
+        <Spinner renderTitle="Loading" delay={300} />
+      )
 
       const spinnerElements = container.querySelectorAll('[data-cid="Spinner"]')