Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning should be spelt correctly. #365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jjasghar
Copy link
Member

It looks like beginning was spelt incorrectly.

/cc @nimbinatus

@mergify mergify bot added the ci-failure label Dec 11, 2024
@JamesKunstle
Copy link
Contributor

Is beginingoftext correct or should it be beginningoftext

@nathan-weinberg
Copy link
Member

@Mergifyio rebase

It looks like beginning was spelt incorrectly.

Co-authored-by: Laura Santamaria <[email protected]>
Signed-off-by: JJ Asghar <[email protected]>
Copy link
Contributor

mergify bot commented Dec 17, 2024

rebase

✅ Branch has been successfully rebased

@@ -9,7 +9,7 @@
assistant=TokenInfo("<|assistant|>", add_to_tokenizer=True),
eos=TokenInfo("<|endoftext|>", add_to_tokenizer=True),
pad=TokenInfo("<|pad|>", add_to_tokenizer=True),
bos=TokenInfo("<|begginingoftext|>", add_to_tokenizer=True),
bos=TokenInfo("<|beginingoftext|>", add_to_tokenizer=True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bos=TokenInfo("<|beginingoftext|>", add_to_tokenizer=True),
bos=TokenInfo("<|beginningoftext|>", add_to_tokenizer=True),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants