Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech jokes taxonomy contribution #511

Closed
wants to merge 10 commits into from
Closed

Conversation

nhaklik
Copy link

@nhaklik nhaklik commented Mar 14, 2024

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Tech jokes taxonomy contribution

Taxonomy contribution by adding tasks that enables telling jokes related to technology.

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

@nhaklik nhaklik requested a review from a team as a code owner March 14, 2024 15:30
@bmr-cymru
Copy link

The file should always be called qna.yaml, in this case you want to put it in a subdirectory named techjokes.

It also might be worth editing the file so that the question/answer pairs are in the same order - your first example has question then answer, but the second has the answer first. It might be more readable to have them both the same way around.

@bmr-cymru
Copy link

Also similar to #509

@nhaklik nhaklik marked this pull request as draft March 14, 2024 18:36
…chjokes.yaml to compositional_skills/writing/freeform/jokes/puns/techjokes/qna.yaml

Signed-off-by: nhaklik <[email protected]>
@nhaklik
Copy link
Author

nhaklik commented Mar 14, 2024

@bmr-cymru Thank you for the observations, I have changed the file name and the format. I have also checked against any duplicates with the other similar MR.

@nhaklik nhaklik marked this pull request as ready for review March 15, 2024 13:51
@mairin mairin added the skill (Auto labeled) label Mar 16, 2024
nhaklik added 3 commits March 19, 2024 13:15
Fixing yamllint issues

Signed-off-by: nhaklik <[email protected]>
Added two new sets of Q&A.

Signed-off-by: nhaklik <[email protected]>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Mar 25, 2024
@jjasghar
Copy link
Member

Thank you for taking the time to submit to instruct-lab! I know this wasn't easy and could have been quite time-consuming. Unfortunately, our team has decided that submissions for jokes or poems (skills and knowledge) are no longer supported or approved. We received so many at the beginning, and with jokes being "in the eye of the beholder" and puns requiring nuance for native English speakers, we realized we were possibly unconsciously biasing our model. We have discovered that working with both topics has its own challenges, and if we want something generalized, finding consensus was unsuccessful.

We have updated the avoid topics to reflect this, and if you have more questions, don't hesitate to comment on this PR. We may revisit this in the future, but we are looking for unique skills or new knowledge for the model; poems and jokes, unfortunately, don't fit this plan.

Thank you again for taking this time, and we are looking forward to your next PR to the instruct-lab project!

@jjasghar jjasghar closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill (Auto labeled) triage-needed (Auto labeled) skill is ready to be triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants