Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMC DeLorean (combined) #1156

Closed
wants to merge 3 commits into from
Closed

DMC DeLorean (combined) #1156

wants to merge 3 commits into from

Conversation

ckadner
Copy link
Contributor

@ckadner ckadner commented Jun 4, 2024

Describe the contribution to the taxonomy

Combined knowledge submissions for DMC DeLorean from Red Hat Summit 2024.

Closes #887
Closes #889
Closes #890
Closes #933
Closes #938
Closes #949
Closes #1003
Closes #1006
Closes #1022
Closes #1050

Resolves #824

FYI @SEHANTA, @arxspecialist, @cpgill1, @jessygluekler, @joebelford, @mguginf, @nsthompson, @redhatconfuser1, @zsplaingard, @mattbrown1477

Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • All commits are signed off (DCO)
  • The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • Content does not include PII or otherwise sensitive or confidential information
  • Content does not include anything documented in the project's Avoid these Topics guidelines

Combined knowledge submissions for DMC DeLorean from Red Hat Summit 2024.

Closes instructlab#887
Closes instructlab#889
Closes instructlab#890
Closes instructlab#933
Closes instructlab#938
Closes instructlab#949
Closes instructlab#1003
Closes instructlab#1006
Closes instructlab#1022
Closes instructlab#1050

Resolves instructlab#824

Co-authored-by: SEHANTA <[email protected]>
Co-authored-by: zsplaingard <[email protected]>
Co-authored-by: Nick Thompson <[email protected]>
Co-authored-by: joeb_1369 <[email protected]>
Co-authored-by: cpgill1 <[email protected]>
Co-authored-by: arxspecialist <[email protected]>
Co-authored-by: mguginf <[email protected]>
Co-authored-by: Jessy Glükler <[email protected]>
Co-authored-by: redhatconfuser1 <[email protected]>
Co-authored-by: mattbrown1477 <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Jun 4, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@ckadner ckadner marked this pull request as draft June 4, 2024 08:30
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Copy link
Contributor Author

ckadner commented Jun 4, 2024

@juliadenham @kelbrown20 -- similar to Prince Leopold Island, there are some key numerical values missing from the Markdown, like the miles per hour figures below


https://en.wikipedia.org/wiki/DMC_DeLorean#Performance

DMC's comparison literature noted that the DeLorean could achieve 0–60 miles per hour (0–97 km/h) in 8.8 seconds when equipped with a manual transmission, but other sources indicate an acceleration time of 9.5 seconds. When equipped with a manual transmission, the DeLorean accelerated from 0 to 60 miles per hour (0 to 97 km/h) in 10.5 seconds as tested by Road & Track magazine. Top speed was claimed at 130 mph (209 km/h), but was tested to be a lacking 110 mph (177 km/h). Car & Driver put the top speed of a 5-speed manual at 117 mph (188 km/h) (indicated)

https://github.com/juliadenham/Summit_knowledge/blob/main/DMC_DeLorean.md#performance

DMC's comparison literature noted that the DeLorean could achieve in 8.8 seconds when equipped with a manual transmission, but other sources indicate an acceleration time of 9.5 seconds. When equipped with a manual transmission, the DeLorean accelerated from in 10.5 seconds as tested by Road & Track magazine. Top speed was claimed at , but was tested to be a lacking . Car & Driver put the top speed of a 5-speed manual at (indicated).

===

https://en.wikipedia.org/wiki/DMC_DeLorean#Base_price

Upon release in 1981, a DeLorean had a base MSRP of $25,000, or equivalent to $84,000 in 2023. MSRP increased in 1982 to $29,825,[57] equivalent to $94,000 in 2023, and again in 1983 to $34,000,[58] equivalent to $104,000 in 2023.

https://github.com/juliadenham/Summit_knowledge/blob/main/DMC_DeLorean.md#base-price

Upon release in 1981, a DeLorean had a base MSRP of $25,000, or . MSRP increased in 1982 to $29,825, , and again in 1983 to $34,000, .


Should we update the Markdown files or remove all questions that are referring to missing numbers?

@ckadner ckadner marked this pull request as ready for review June 4, 2024 08:32
@juliadenham
Copy link
Contributor

juliadenham commented Jun 4, 2024

Hi @ckadner , I'm not sure how that happened in the markdown file but can fix it and add a new commit hash in the spreadsheet. Thanks for catching that

@ckadner
Copy link
Contributor Author

ckadner commented Jun 4, 2024

#1160

@mingxzhao
Copy link
Member

@instructlab-bot precheck

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 404. The results will be presented below in the pull request status box. This may take several minutes...

@mingxzhao
Copy link
Member

@instructlab-bot generate

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: sdg-svc. Your Job ID is 405. The results will be presented below in the pull request status box. This may take several minutes...

Copy link

Results for job ID: 404 using the model instructlab/granite-7b-lab!

Results can be found here.

Copy link

Results for job ID: 405 using the model sdg service backend!

Results can be found here.

Signed-off-by: Christian Kadner <[email protected]>
@jjasghar
Copy link
Member

@instructlab-bot precheck

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 419. The results will be presented below in the pull request status box. This may take several minutes...

@jjasghar jjasghar added precheck-generate-ready PR is ready for precheck or generate step and removed triage-needed (Auto labeled) skill is ready to be triaged labels Jun 18, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

Copy link

Results for job ID: 419 using the model instructlab/granite-7b-lab!

Results can be found here.

Copy link

github-actions bot commented Jul 4, 2024

This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Jul 4, 2024
@jjasghar jjasghar removed stale stale-bot has marked you as stale precheck-generate-ready PR is ready for precheck or generate step labels Jul 5, 2024
@jjasghar jjasghar added the community-build-ready Triage Team has signed off for synthetic data generation label Jul 5, 2024
@jjasghar
Copy link
Member

Hi! 👋
With the new update and release of 0.18.0, our base knowledge submissions have drastically changed. This has given us an opportunity to significantly improve the accuracy of our fine-tuned models, which is a major win for our community!

But alas, that has caused some changes that this PR isn't able to continue forward. We greatly appreciate the work you've put into this, and wish we could accept it but the amount of work to get it to be version: 3 is unrealistic for us to ask.
If you do want to do this, please don't hesitate to take the qna.yaml update it, and build it out. Otherwise, we hope you come back to our community with a new submission and help build out our Open Source community-driven LLM.

If you have any questions directly, please don't hesitate to comment on the PR or email me at awesomeATinstructlab.ai (yes, really), and I'll do my best to answer your questions.

@jjasghar jjasghar closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-build-ready Triage Team has signed off for synthetic data generation knowledge (Auto labeled)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMC DeLorean
4 participants