Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for dedicated local storage in ilab cli #104
base: main
Are you sure you want to change the base?
Add doc for dedicated local storage in ilab cli #104
Changes from 1 commit
d6c81b3
93ac391
2ba3e5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI itself doesn't manage any of this. It's user config. It generates an initial file for you, but never updates it from there. I only bring this up because user config isn't the same as data that is never touched directly by a user. (config vs data)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point, I would say it makes a stronger point for the proposed structure of the
~/.local/share
directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be so @RobotSail but as @russellb mentioned the CLI doesn't manage this.
Check failure on line 17 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably this works on windows with WSL? I know people have been using it on WSL, already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's WSL then we should still assume it's a linux system. The only WSL-specific bits are more on the CUDA drivers side. And even then, that works fine currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking more of "raw windows", but you're right - WSL is a great alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobotSail Are qwe going to support native Windows? if not, we should be explicit that it is WSL.
Check failure on line 23 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Trailing spaces
Check failure on line 26 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
Check failure on line 35 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
Check failure on line 42 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Trailing spaces
Check failure on line 53 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
Check failure on line 64 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
Check failure on line 71 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
Check failure on line 74 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Multiple consecutive blank lines
Check failure on line 76 in docs/cli/ilab-local-config.md
GitHub Actions / markdown-lint
Trailing spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a distinct proposal, was there a reason you included it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is definitely distinct, but will be something we'll need as a feature in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A way this can work is have a data_dir that can be changed via a CLI flag or config file option, but always default to what you have specified here -- very similar to what you describe as a default location for the config dir unless otherwise specified via a flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having trouble understanding what you mean on this sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@n1hility My wording here is bad but the idea is simple:
~/.config/ilab/config.yaml
then parse paths relative to~/.local/share/ilab
.ilab
is invoked in/foo
and theconfig.model_path
references a file inbar/granite_7b.gguf
then it would resolve to/foo/bar/granite_7b.gguf
.