Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Commit

Permalink
Fix migration recipe
Browse files Browse the repository at this point in the history
  • Loading branch information
@aarongerig
aarongerig committed Dec 27, 2017
1 parent 00244ea commit d9b6bc6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion recipes/pimcore.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@
});

task('deploy:pimcore:migrate', function() {
run('{{bin/console}} pimcore:migrations:migrate');
run('{{bin/php}} {{release_path}}/bin/console pimcore:migrations:migrate');
});

9 comments on commit d9b6bc6

@dpfaffenbauer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/console should exist from the symfony recipes, why doesn't it work?

@aarongerig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this wasn't tested. Maybe we should revert this?

@dpfaffenbauer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test before commit ;)

@aarongerig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but as you can imagine I was prefixing everything with the bin/php to make sure it works with Windows as well. ;)

@aarongerig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just noticed, that the install-classes command also uses the php-binary as prefix, hence the reason I changed this in the first place. Don't you think that this is correct then?

@dpfaffenbauer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact: bin/console should be prefixed with php. Not sure if it is, but it should be

@aarongerig
Copy link
Member Author

@aarongerig aarongerig commented on d9b6bc6 Dec 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like it... https://github.com/deployphp/deployer/blob/5a8246aed2042e3d229ae3f96fc2e75b69e66ce9/recipe/symfony.php#L50-L52

I guess I'll leave it then.

@aarongerig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about that? 27dfaf6

@dpfaffenbauer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s even worse. Let’s keep it with bin/php bin/console for now. I’ll figure something out

Please sign in to comment.