INSTA-16822: Build on ubuntu+clang17, fix cross-build, QA #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the build from DockerHub debian:testing to ubuntu:22.04. Attention: Clang version on this image is 17, not 16. Isolate docker files in directory docker-image. Introduce an entrypoint for the docker image, to better deal with the GO environment. Dockerfile: install GolangCi deps in the docker image, copy the binaries in the container's workdir in /agent/go/bin. Makefile: fix the clean target. Makefiles: substitute clang-16 with clang. Makefile: remove the installation of GolangCi deps during linting. Makefile: add targets for GO deps management Makefile: pin GO deps versions Makefile: pin porto version to "v0.6.0" (instead of latest). The latest version of porto requires GO 1.23, while the current toolchain is based on Go 1.22. Makefile: improve target linter-version, print all GolangCi deps versions. GO: touch go/bin/.gitkeep, the directory bin contains the GO deps print_instruction_count: fix OBJDUMP_CMD from llvm-objdump-16 to llvm-objdump. Makefile: Fix cross-compilation Always use NATIVE_ARCH as GOARCH for go:generate. The previous approach may fail on systems that can not execute cross-compiled binaries on the build host (e.g. if an appropriate qemu binary is not installed).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Jira ticket
WHAT
debian:testingtodelivery.instana.io/int-docker-private-virtual/ubuntu:22.04Attention: Clang version on this image is 17, not 16.
docker-imageThe docker image entrypoint moves to /agent/go/bin all the binaries needed by GO for the generation and linting
Attention: pin porto version to "v0.6.0" (instead of latest). The latest version of porto requires GO 1.23.
WHY
2-8: Fixes