Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra 12937 instaclustr #66

Open
wants to merge 17 commits into
base: CASSANDRA-12937
Choose a base branch
from

Conversation

Claudenw
Copy link

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@Claudenw
Copy link
Author

@smiklosovic I think this change solves some of the problems with determining the system keyspaces.

Basically everyplace we call CompressionParams.defaultParams() we know the keyspace. So just pass it and make all the system keyspace resolution code for CompressionParams in the defaultParams call. Keep it in one place so we only have one place to look for changes.

@Claudenw
Copy link
Author

Removed some unintentional changes.

@Claudenw
Copy link
Author

@smiklosovic Do you think you want to proceed with this? I think we can make this work cleanly and efficiently fairly quickly

@Claudenw
Copy link
Author

Claudenw commented Mar 5, 2024

@smiklosovic , Do you think you can merge this pull into your branch so we can update the master pull request for 12937. I would like to see this get in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants