issue-108, unnecessary comments and code were removed

[DoodgeMatvey]

Closes #108

[testisnullus]

@rukai Should we also include #8 in this PR?

[cjrolo]

Some TODO's have broad implications, let them stay in place OR create a issue for each one of them seems a better option.

[testisnullus]

Ok, let's keep the TODOs, I am going to review them and create separate issues for the important ones

[cjrolo]

@testisnullus can you check the conflicts and resolve them?

Thanks!

[DoodgeMatvey]

@testisnullus can you check the conflicts and resolve them?

Thanks!

I checked and resolved them

[cjrolo]

Let's remove:

• prometheus-remote (It is too broken to make sense)
• tools/dwt_finder.rs (It was a test tool)
• tools/flac_reader_tester.rs (It was a test tool)
• tools/mid_channel_computing.rs (It was a test tool)
• optimizer (It was related to prometheus and the WAV format)

I will continue the review but let's do these things in the meanwhile.

[cjrolo]

Also this is removing a lot of comments. I would focus on removing unused code paths/structures and less on comments. They are a protection for our (and others) future selfs.

[DoodgeMatvey]

Also this is removing a lot of comments. I would focus on removing unused code paths/structures and less on comments. They are a protection for our (and others) future selfs.

There are a lot of comments like

• /// Function to perform compression and make a decision based on the results.
  Func name compress_and_decide()
• // Initialize the compressor let c = Constant::new(data.len(), stats.min, stats.bitdepth); // Convert to bytes CompressorResult::new(c.to_bytes(), 0.0)
• /// Stored frequencies
pub frequencies: Vec<FrequencyPoint>,
• ///Optimize
pub fn optimize(data: &[f64]) -> Vec<i64> {
• /// "Compress"
pub fn compress(&mut self, data: &[f64]) {

Almost all comments that were removed looked like these. In such cases code is self-documented. Should I recover them?

[cjrolo]

The self explanatory can go.

Thanks

[cjrolo]

Cargo.toml needs to be updated and the non-used projects removed.

[DoodgeMatvey]

Let's remove:

• prometheus-remote (It is too broken to make sense)
• tools/dwt_finder.rs (It was a test tool)
• tools/flac_reader_tester.rs (It was a test tool)
• tools/mid_channel_computing.rs (It was a test tool)
• optimizer (It was related to prometheus and the WAV format)

I will continue the review but let's do these things in the meanwhile.

Removed

[DoodgeMatvey]

Cargo.toml needs to be updated and the non-used projects removed.

Yes, updated

[DoodgeMatvey]

The self explanatory can go.

Thanks

I left only meaningful comments and deleted unnecessary ones.

[cjrolo]

Can we check if this whole file can go? This is from the early implementations and we no longer have a definition of metric (or tags) inside the compressor.

[DoodgeMatvey]

Checked, and removed because it wasn't used anywhere

[cjrolo]

There is a couple of comments, but they can be address later.

Thanks for this PR is a massive cleanup effort that needed to be done!

[testisnullus]

LGTM! @cjrolo Let's merge this PR before I start to refactor a code to rename the tool to ATSC (#126) completely.

[worryg0d]

The preprocessor folder looks redundant since it contains only empty mod.rs.