Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add ViewFactory.Params type that includes android context. #406

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[Android] Add ViewFactory.Params type that includes android context. #406

merged 1 commit into from
Dec 6, 2024

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Dec 6, 2024

What

Creating ViewFactory.Params type which encapsulates context, layoutInflater, and container properties.

@carrotkite
Copy link

1 Warning
⚠️ No coverage data found for com/instacart/formula/android/ViewFactory

JaCoCo Code Coverage 97.09% ✅

Class Covered Meta Status
com/instacart/formula/android/ViewFactory No coverage data found : -% No coverage data found : -% 🃏
com/instacart/formula/android/LayoutViewFactory 100% 0% ✅
com/instacart/formula/android/FragmentEnvironment 100% 0% ✅
com/instacart/formula/android/FormulaFragment 88% 0% ✅
com/instacart/formula/android/internal/FormulaFragmentViewFactory 100% 0% ✅

Generated by 🚫 Danger

@Laimiux Laimiux merged commit 6901e9a into master Dec 6, 2024
4 checks passed
@Laimiux Laimiux deleted the laimonas/view-factory-params branch December 6, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoisBlavoet FrancoisBlavoet FrancoisBlavoet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laimiux @carrotkite @FrancoisBlavoet