Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add onPreRenderFragmentState callback. #404

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ import io.reactivex.rxjava3.disposables.Disposable
* configuration changes. Check [com.instacart.formula.android.StreamConfigurator] for utility methods.
* @param configureActivity This is invoked as part of [com.instacart.formula.FormulaAndroid.onPreCreate]. You can
* use this callback to inject the activity.
* @param onRenderFragmentState This is invoked after [FragmentState] has been updated.
* @param onPreRenderFragmentState This is invoked before [FragmentState] is applied.
* @param onRenderFragmentState This is invoked after [FragmentState] has been applied.
* @param onFragmentLifecycleEvent This is callback for when a fragment is added or removed.
*/
class ActivityStore<Activity : FragmentActivity>(
val fragmentStore: FragmentStore = FragmentStore.EMPTY,
val streams: (StreamConfigurator<Activity>.() -> Disposable)? = null,
val configureActivity: ((Activity) -> Unit)? = null,
val onPreRenderFragmentState: ((Activity, FragmentState) -> Unit)? = null,
val onRenderFragmentState: ((Activity, FragmentState) -> Unit)? = null,
val onFragmentLifecycleEvent: ((FragmentLifecycleEvent) -> Unit)? = null
)
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ internal class ActivityManager<Activity : FragmentActivity>(
val renderView = fragmentRenderView ?: throw callOnPreCreateException(activity)

uiSubscription = delegate.fragmentState().subscribe {
store.onPreRenderFragmentState?.invoke(activity, it)
renderView.render(it)
store.onRenderFragmentState?.invoke(activity, it)
}
Expand Down
Loading