Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set fragment instance id to all fragments. #401

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Set fragment instance id to all fragments. #401

merged 1 commit into from
Oct 10, 2024

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Oct 10, 2024

What

For consistency, changing this to set instanceId to all fragments (instead of BaseFormulaFragment only)

@Laimiux Laimiux requested a review from Jawnnypoo October 10, 2024 17:58
@carrotkite
Copy link

JaCoCo Code Coverage 97.15% ✅

Class Covered Meta Status
com/instacart/formula/android/internal/FragmentLifecycle 75% 0% ✅

Generated by 🚫 Danger

@Laimiux Laimiux merged commit 21955e6 into master Oct 10, 2024
4 checks passed
@Laimiux Laimiux deleted the laimonas/set-fragment-instance-id-for-all branch October 10, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jawnnypoo Jawnnypoo Jawnnypoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laimiux @carrotkite @Jawnnypoo