Rename FragmentStoreBuilder to FeaturesBuilder. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 89.67% ✅
Generated by 🚫 Danger |
Laimiux
force-pushed
the
laimonas/features-builder
branch
from
49b6596 to
db3b8f0
Compare
Laimiux
force-pushed
the
laimonas/features-builder
branch
from
db3b8f0 to
1013f03
Compare
Jawnnypoo
reviewed
Sep 4, 2024
| @@ -29,7 +30,7 @@ class FragmentAndroidEventTest { | |||
| configureActivity = { | |||
| initialContract = TestLifecycleKey() | |||
| }, | |||
| contracts = { | |||
| fragmentStore = FragmentFlowStore.init { | |||
There was a problem hiding this comment.
Should we consider a rename from FragmentFlowStore to maybe just FragmentStore as well? When I see Flow, I always just think Coroutine Flow so it can be a little jarring to realize that its not that.
There was a problem hiding this comment.
Agreed, will do in a follow up.
Jawnnypoo
approved these changes
Sep 4, 2024
Laimiux
force-pushed
the
laimonas/features-builder
branch
from
c122314 to
ecf62dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
FragmentStoreBuildertoFeaturesBuilderFeaturesBuilder.buildnon-internal. This allows us to buildFeatureslist outside ofFragmentFlowStorecontractsparameters tofragmentStore