Fix stale transition bug when using dispatchers. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Mar 15, 2024
| @@ -11,11 +9,10 @@ import com.instacart.formula.Transition | |||
| */ | |||
| class DeferredTransition<Input, State, EventT> internal constructor( | |||
| private val listener: ListenerImpl<Input, State, EventT>, | |||
| private val transition: Transition<Input, State, EventT>, | |||
There was a problem hiding this comment.
This is the primary issue where we could be holding a stale transition.
Laimiux
commented
Mar 15, 2024
| @Volatile internal var manager: FormulaManagerImpl<Input, State, *>? = null | ||
| @Volatile internal var snapshotImpl: SnapshotImpl<Input, State>? = null | ||
| @Volatile internal var executionType: Transition.ExecutionType? = null | ||
| @Volatile private var manager: FormulaManagerImpl<Input, State, *>? = null |
There was a problem hiding this comment.
Making private and using setDependencies to update
JaCoCo Code Coverage 81.49% ✅
Generated by 🚫 Danger |
jasonostrander
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug where
DeferredTransitioncan hold to a staletransitionproperty if a state change happens while event is waiting to be dispatched. Instead, we should rely on the mutable property that lives inListenerImpl