Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small clean up to increase coverate #352

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Small clean up to increase coverate #352

merged 1 commit into from
Mar 15, 2024

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Mar 15, 2024

What

  • Make Cancelable into fun interface
  • Mark not-read internal properties as private

@carrotkite
Copy link

1 Warning
⚠️ No coverage data found for com/instacart/formula/Cancelable

JaCoCo Code Coverage 81.83% ✅

Class Covered Meta Status
com/instacart/formula/internal/OverrideKeyAction 100% 0% ✅
com/instacart/formula/internal/ActionBuilderImpl 100% 0% ✅
com/instacart/formula/internal/JoinedKey 100% 0% ✅
com/instacart/formula/internal/FormulaKey 100% 0% ✅
com/instacart/formula/internal/IndexedKey 100% 0% ✅
com/instacart/formula/FormulaContext 86% 0% ✅
com/instacart/formula/Cancelable No coverage data found : -% No coverage data found : -% 🃏

Generated by 🚫 Danger

@Laimiux Laimiux merged commit 95054a0 into master Mar 15, 2024
3 checks passed
@Laimiux Laimiux deleted the laimonas/increase-coverage-pt1 branch March 15, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laimiux @carrotkite